block: rename need_dispatch to cautious_dispatch in blk-mq sched#887
block: rename need_dispatch to cautious_dispatch in blk-mq sched#887blktests-ci[bot] wants to merge 1 commit into
Conversation
|
Upstream branch: eed108e |
de94ac7 to
86d8d37
Compare
|
Upstream branch: e8c2f9f |
a7d2e76 to
def1d24
Compare
86d8d37 to
9805659
Compare
|
Upstream branch: eb3f4b7 |
def1d24 to
88e85dc
Compare
9805659 to
3f4a345
Compare
|
Upstream branch: 8fde5d1 |
88e85dc to
171151b
Compare
3f4a345 to
c6dc343
Compare
|
Upstream branch: e43ffb6 |
171151b to
c4c23a9
Compare
c6dc343 to
fc36596
Compare
|
Upstream branch: ba3e43a |
c4c23a9 to
41a85d9
Compare
fc36596 to
7bed9c3
Compare
|
Upstream branch: ddd664b |
41a85d9 to
1088930
Compare
7bed9c3 to
a7bb5c5
Compare
|
Upstream branch: 979c294 |
1088930 to
0bb3307
Compare
a7bb5c5 to
5e41a3b
Compare
|
Upstream branch: acb7500 |
0bb3307 to
8097531
Compare
5e41a3b to
c3a084b
Compare
|
Upstream branch: 9716c08 |
8097531 to
fd85eb5
Compare
c3a084b to
5f78e5d
Compare
|
Upstream branch: 2a2974b |
fd85eb5 to
aa40e26
Compare
5f78e5d to
e48f9db
Compare
|
Upstream branch: 062871f |
aa40e26 to
7ada742
Compare
199644a to
e6d9eb8
Compare
|
Upstream branch: 66affa3 |
7ada742 to
3b4f364
Compare
e6d9eb8 to
7d8604f
Compare
The local boolean in __blk_mq_sched_dispatch_requests() decides whether
to fall back to the per-ctx round-robin path (blk_mq_do_dispatch_ctx())
instead of the batch flush path (blk_mq_flush_busy_ctxs()). The whole
function is about dispatching anyway, so the name "need_dispatch" is
not particularly informative and can mislead readers into thinking that
a false value means "skip dispatching".
Rename it to "cautious_dispatch" to match the comment right above the
check ("dequeue request one by one from sw queue if queue is busy")
and to convey the actual intent: take the cautious, fair, one-at-a-time
path either when we just drained hctx->dispatch (so the device has
recently pushed back) or when the dispatch_busy EWMA still indicates
congestion. The fast batch path is only taken when neither signal
suggests recent backpressure.
No functional change.
Signed-off-by: Guixin Liu <kanie@linux.alibaba.com>
|
Upstream branch: bade58e |
3b4f364 to
b25c605
Compare
Pull request for series with
subject: block: rename need_dispatch to cautious_dispatch in blk-mq sched
version: 1
url: https://patchwork.kernel.org/project/linux-block/list/?series=1100976